test: JwtService/UserIdResolver 단위 테스트 추가 + dev CI 테스트 실행 - #212
Conversation
- JwtServiceTest: 토큰 발급/검증/만료/클레임 추출 검증 - UserIdResolverTest: 토큰 누락/만료/무효, 방문자 모드, userId 파싱 및 MDC 반영 검증 - dev-ci.yml: `-x test` 제거 — 지금까지 테스트가 아예 실행 안 되고 있었음
|
Warning Review limit reached
Next review available in: 13 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
-x test 제거 직후 CI에서 ServerApplicationTests가 SocketTimeoutException으로 실패함 — GitHub Actions 러너에서 실제 dev DB/Redis로 네트워크가 안 닿는 게 원인. CI에 postgres/redis 서비스 컨테이너를 띄우고 SPRING_DATASOURCE_URL/ SPRING_DATA_REDIS_HOST 환경변수로 그쪽을 바라보게 해서 해결.
배경
프로젝트에 실질적인 테스트 코드가 전무했음 (
ServerApplicationTests.contextLoads()하나뿐, 로직 검증 없음). 게다가dev-ci.yml이-x test로 테스트 실행 자체를 건너뛰고 있어서, 테스트를 짜도 CI에서 검증이 안 되는 상태였음.오늘 MDC userId 로깅 작업(#211) 하면서 만든
JwtService/UserIdResolver부터 테스트 커버리지 시작.변경 사항
JwtServiceTest: 토큰 발급 후 검증 성공, userId 클레임 추출, 형식 오류/만료 토큰 판정UserIdResolverTest: accessToken/refreshToken 누락, 방문자 모드, 만료/무효 토큰, 정상 토큰의 userId 파싱 및 MDC 반영, 숫자 아닌 클레임 예외dev-ci.yml:-x test제거검증
JwtServiceTest4개,UserIdResolverTest8개)./gradlew build전체(기존ServerApplicationTests포함) 통과 확인